Support Accessibility Custom Content #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyalPineapple
force-pushed
the
alex/AXCustomContent
branch
2 times, most recently
from
2d1d451
to
8344c7a
Compare
RoyalPineapple
force-pushed
the
alex/AXCustomContent
branch
from
0e5d426
to
ac7e623
Compare
RoyalPineapple
changed the title
RoyalPineapple
force-pushed
the
alex/AXCustomContent
branch
6 times, most recently
from
2a80a13
to
d0387e9
Compare
RoyalPineapple
commented
Jan 23, 2024
NickEntin
reviewed
Jan 24, 2024
RoyalPineapple
force-pushed
the
alex/AXCustomContent
branch
from
da22552
to
ba47226
Compare
n8chur
approved these changes
Jan 29, 2024
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilityHierarchyParser.swift
Outdated
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilityHierarchyParser.swift
Outdated
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilityHierarchyParser.swift
Outdated
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilitySnapshotView.swift
Outdated
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilitySnapshotView.swift
Outdated
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilitySnapshotView.swift
Show resolved
Hide resolved
NickEntin
reviewed
Jan 30, 2024
Example/AccessibilitySnapshot/AccessibilityCustomContentViewController.swift
Outdated
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilityHierarchyParser.swift
Outdated
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilitySnapshotView.swift
Outdated
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilitySnapshotView.swift
Show resolved
Hide resolved
Example/AccessibilitySnapshot/AccessibilityCustomContentViewController.swift
Show resolved
Hide resolved
RoyalPineapple
force-pushed
the
alex/AXCustomContent
branch
2 times, most recently
from
8ae74e8
to
89ec74e
Compare
RoyalPineapple
force-pushed
the
alex/AXCustomContent
branch
from
c0ed06d
to
ea85500
Compare
Merged
|
The failing iOS 16 CI job should be fixed now with #209. If you rebase on latest main, that build should start passing. |
NickEntin
reviewed
Feb 20, 2024
Example/AccessibilitySnapshot/AccessibilityCustomContentViewController.swift
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilityHierarchyParser.swift
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilityHierarchyParser.swift
Outdated
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilityHierarchyParser.swift
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Classes/AccessibilitySnapshotView.swift
Show resolved
Hide resolved
meherkasam
reviewed
Feb 20, 2024
|
|
||
| // MARK: - | ||
|
|
||
| private final class CustomContentView: UIView { |
There was a problem hiding this comment.
@NickEntin Not an item for this PR, but this file is starting to get fairly large. Would it be worthwhile refactoring the subclasses into their own files?
There was a problem hiding this comment.
Yeah, it's probably time 👍
meherkasam
approved these changes
Feb 20, 2024
RoyalPineapple
force-pushed
the
alex/AXCustomContent
branch
2 times, most recently
from
f686cb1
to
3c5fa8b
Compare
RoyalPineapple
force-pushed
the
alex/AXCustomContent
branch
from
9b29415
to
5b1b27a
Compare
RoyalPineapple
force-pushed
the
alex/AXCustomContent
branch
from
5b1b27a
to
2f24559
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in iOS 14 Accessibility Custom Content allows the inclusion of arbitrary accessibility content defined using pairs of label and value.
As a default this additional data is exposed under a "Custom Content" rotor entry, but can also be included in the element's VoiceOver utterance by setting the content's
importanceinstance variable to.highor by adjusting verbosity in VoiceOver settings.This PR adds support for displaying custom content similar to how we handle custom actions.