sync upstream #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersioned constants Starknet 0.13.2.1 introduces a new set of versioned constants which we'll have to handle.
This defaulted to the L2 poll interval, which is 2s right now. This is completely unjustified and just results in us polling L1 with a much higher rate than expected. This change adds the `--sync.l1-poll-interval` CLI option that defaults to 30s.
We do check the continuation token before appending pending events to the result set. However, the check was too strict: in case of an extract block number match we used the offset from the token and we returned an error in all other cases. Unfortunately this breaks in the completely valid case where a continuation token was in the request pointing to the non-pending block but the page was not full with results from the database yet so we go on appending events from the pending block. This change fixes the check: if the block number in the token is _before_ the pending block we simply start from offset 0 instead of returning an error. Closes: eqlabs#2191
…de-for-0.13.2.1 feat(crates/executor): upgrade blockifier to 0.8.0-rc.3 and add new versioned constants
…bugfixes chore: backport some fixes to 0.14.2
…re disabled" This reverts commit 6368178.
chore: bump version number to 0.14.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.