Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #80 and almost complete #81

Open
wants to merge 18 commits into
base: gh-pages
Choose a base branch
from

Conversation

bagustris
Copy link
Contributor

@bagustris bagustris commented Apr 19, 2024

Preview available at: https://bagustris.github.io/shell-extras/

@@ -170,10 +169,10 @@ whitespace to separate command, options (flags) and parameters /
arguments. For the same reason it is essential that the command (or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should probably be a callout box rather than a dedicated subsection? GH won't let me comment on the ### **Important** line above though :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -237,14 +235,13 @@ loops.
> ~~~
> but for *each* of the `.pdb`-files.
<!-- solution: for file in *.pdb; do sort $file > $(basename $file .pdb).sorted; done -->
{: .challenge}

## Closing remarks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This chapter is missing "Key Points", so the respective box is empty :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This chapter is also missing "Key Points"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do pages under _extras end up in the rendered output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually added help.md and config.md for backup when these references disappear, I didn't touch other setting so I don't know how to add these to extras.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants