Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to use directory name as url #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

takuyozora
Copy link

Hi,

Same idea that #138, I've wrote a small patch to allow the password directory name to by used as URL, so for example, with :web/github.com/takuyozora the URL will be github.com.

@carnager
Copy link
Owner

carnager commented Aug 2, 2018

This needs some checking if the result is an actual URL

@moviuro
Copy link
Contributor

moviuro commented Aug 2, 2018

@takuyozora Also, that's a weird way to use pass. You're leaking more than just metadata, you're actively displaying your username too.

My pass files look like: social/{facebook,twitter,reddit}.com, purchases/{steampowered,amazon}.com, etc.

@carnager you... really don't want to do that by hand. I suggest using a dependancy or whatever, but I think building an URL checker is out of scope for rofi-pass (and also, really a can of worms).

@takuyozora
Copy link
Author

@carnager
My first though was to add a config variable to activate or not url from directory, but it's also possible to check for valid URL with grep or directly in bash (>=3.2), see : here or here.

@moviuro
As I said in my other PR (#138) I only use this for unsensitive account. There is so many website where only a 16 length random password is strong enough. For the other I just add a user field that override the user from filename functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants