Skip to content

Commit

Permalink
aws-sam-cli: retain non-native binaries
Browse files Browse the repository at this point in the history
These binaries are for use inside containers which might be running a
different architecture.

Also, add this to the autobump list since upstream has issues when there
are delayed updates to users.

Fixes Homebrew/discussions#4290
Fixes aws/aws-sam-cli#4771
Fixes aws/aws-sam-cli#4684
Fixes aws/aws-sam-cli#4607
Closes aws/aws-sam-cli#4614

Closes Homebrew#124616.

Signed-off-by: Carlo Cabrera <[email protected]>
  • Loading branch information
carlocab committed Mar 3, 2023
1 parent e65aa98 commit f092c3b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
1 change: 1 addition & 0 deletions .github/workflows/autobump.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ env:
aws-elasticbeanstalk
aws-es-proxy
aws-rotate-key
aws-sam-cli
azcopy
b3sum
bagit
Expand Down
8 changes: 1 addition & 7 deletions Formula/aws-sam-cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ class AwsSamCli < Formula
url "https://files.pythonhosted.org/packages/00/04/6c97aa9539c712fa987c2e4f926c4bb7c78083718cc39548a82f9b370023/aws-sam-cli-1.75.0.tar.gz"
sha256 "02f7f4723dd567a7bb9807f74469ee81601634de257da9d7869b604c63759626"
license "Apache-2.0"
revision 1

bottle do
sha256 cellar: :any, arm64_ventura: "762e71080b0715d189b3050a1538ec8dae582c8ff14b5c45e22da67842fe2d10"
Expand Down Expand Up @@ -293,13 +294,6 @@ def python3

def install
virtualenv_install_with_resources

# remove non-native architecture `aws-lambda-rie` binary
site_packages = Language::Python.site_packages(python3)
rapid_path = libexec/site_packages/"samcli/local/rapid/"
rapid_path.each_child do |f|
f.delete if f.file? && f.basename.to_s.exclude?(Hardware::CPU.arch.to_s)
end
end

test do
Expand Down
1 change: 1 addition & 0 deletions audit_exceptions/mismatched_binary_allowlist.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[
"aws-sam-cli",
"balena-cli",
"faust",
"lima",
Expand Down

0 comments on commit f092c3b

Please sign in to comment.