Kes expiration fixes #1839
Merged
Kes expiration fixes #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aunch/pool list/pool show
…art of pool list action
Scitz0
requested changes
Nov 24, 2024
| @@ -762,13 +762,14 @@ isPoolRegistered() { | |||
| unset p_active_epoch_no p_vrf_key_hash p_margin p_fixed_cost p_pledge p_reward_addr p_owners p_relays p_meta_url p_meta_hash p_meta_json p_pool_status | |||
| unset p_retiring_epoch p_op_cert p_op_cert_counter p_active_stake p_epoch_block_cnt p_live_stake p_live_delegators p_live_saturation | |||
| if [[ ${CNTOOLS_MODE} != "LIGHT" ]]; then | |||
| [[ -f "${POOL_FOLDER}/${1}/${POOL_REGCERT_FILENAME}" ]] && return 2 || return 1 | |||
| [[ -f "${POOL_FOLDER}/${1}/${POOL_REGCERT_FILENAME}" ]] && return 2 || (rm -rf "${POOL_FOLDER}/${1}/${POOL_CURRENT_KES_START}" && return 1) | |||
There was a problem hiding this comment.
Should maybe remove recursive flag as we are trying to delete a single file. So no misshaps happen if variables are unset
| if [[ ! -f "${pool}/${POOL_CURRENT_KES_START}" ]]; then | ||
| continue | ||
| fi | ||
|
|
||
| unset pool_kes_start |
There was a problem hiding this comment.
Can remove unset of pool_kes_start as we always overwrite it on line below.
Scitz0
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvements to KES expiration information calculation/display on cntools launch, as well as pool -> list and pool -> show pages.
Where should the reviewer start?
Motivation and context
Which issue it fixes?
How has this been tested?