Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove single quotes from headers array. #1818

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

TrevorBenson
Copy link
Collaborator

Description

Removes the single quote wrapping from the KOIOS_API_HEADERS array

Motivation and context

Even though manual testing w/ curl and koios shows including single quotes wrapped in double persists the string encapsulation expected by curl for headers, this is leading to errors in cntools.sh usage.

Which issue it fixes?

Closes #1817

How has this been tested?

Running wallet list, wallet show, pool list and pool show in light mode when ENABLE_KOIOS=Y.

@TrevorBenson TrevorBenson requested review from rdlrt and Scitz0 September 7, 2024 06:28
@rdlrt rdlrt merged commit aa327e7 into alpha Sep 7, 2024
2 checks passed
@rdlrt rdlrt deleted the koios-headers-single-quote-issues branch September 7, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KOIOS_API_HEADERS array issues
2 participants