getProtocolParams use CNCLI if ENABLE_KOIOS=N #1808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables KOIOS access from getProtocolParams if ENABLE_KOIOS is set to N.
Motivation and context
Found unexpected KOIOS API access when trying to completely disable KOIOS. I had set both ENABLE_KOIOS and USE_KOIOS_API to N, but still found cases where traffic was hitting KOIOS endpoints.
Which issue it fixes?
Closes #1807
How has this been tested?
From inside a container using bash -x and capturing stderr to stdout and confirming the curl to cli_protocol_params API route no longer occurs when cncli.sh leaderlog is executed. Also using tcpdump to just examine traffic destined for the IP address of guild.koios.rest.