Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mithril signers section outside of main gLiveView views. #1796

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

TrevorBenson
Copy link
Collaborator

@TrevorBenson TrevorBenson commented Aug 1, 2024

Description

Adds additional conditional requirements && [[ ${show_peers} == "false" ]] && [[ ${show_home_info} == "false" ]] to the section printing the mithril signers details.

Motivation and context

Only display mithril signers in the main gLiveView window, not during peer analysis views.

Which issue it fixes?

closes #1795

How has this been tested?

  1. Making the changes in the commits from this branch.
  2. Loading gLiveView custom version.
  3. Checking peer analsysis view with p
  4. Checking info view with i
  5. Observed mithril signers section no longer appears in either view
  6. Checked verbose with v, confirming same intended behavior for mithril signer section.

@TrevorBenson TrevorBenson requested review from rdlrt and Scitz0 August 1, 2024 17:22
@TrevorBenson TrevorBenson force-pushed the mithril-signer-not-during-peer-analysis branch from 65d5f26 to d7c8e64 Compare August 1, 2024 17:23
@Scitz0
Copy link
Contributor

Scitz0 commented Aug 2, 2024

Might be better just just move entire block into else block where CORE section stuff is printed.
Then there is no need for additional flags.

@TrevorBenson TrevorBenson force-pushed the mithril-signer-not-during-peer-analysis branch from d7c8e64 to 7fdc0dc Compare August 2, 2024 22:08
@TrevorBenson
Copy link
Collaborator Author

Might be better just just move entire block into else block where CORE section stuff is printed. Then there is no need for additional flags.

Done. Inside the else, after Core Section. Allowing SPO's with Mithril Signers running on both core and relay to leverage mithril signer section details.

Copy link
Contributor

@Scitz0 Scitz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Scitz0 Scitz0 merged commit d0cf528 into alpha Aug 2, 2024
1 check passed
@Scitz0 Scitz0 deleted the mithril-signer-not-during-peer-analysis branch August 2, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gLiveView] Mithril signer in Peer Analysis and Info
2 participants