Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNTools multisig #1776

Merged
merged 80 commits into from
Jul 16, 2024
Merged

CNTools multisig #1776

merged 80 commits into from
Jul 16, 2024

Conversation

Scitz0
Copy link
Contributor

@Scitz0 Scitz0 commented Jun 7, 2024

Description

Adds a couple of new larger features within CNTools:

  • Multisig wallet support through advanced menu item.
  • Custom mnemonic derivation path on mnemonic/hardware import and creation of new mnemonic(seedphrase) generated wallet.
  • New Vote menu option to hold everything related to voting on Cardano incl Catalyst registration integration.

Task List:

  • Derive multisig keys according to CIP-1854 for mnemonic and hardware wallets, or new cli keys
  • Create a multisig wallet specifying participants by wallet selection or manual cred input.
    • Time lock support using after directive.
    • Constructed using atLeast directive allowing any number of signatures.
  • Wallet list/show extended to show additional details
    • normal wallets: key credentials (both multisig keys and regular keys).
    • multisig wallets: script parsing to show participants, either local wallets or external with credentials.
  • All transaction building code updated to handle payment and stake scripts in addition to normal keys. If a multisig wallet is detected, an offline transaction file is generated just like in hybrid mode.
  • Transaction >> Sign: updated to handle scripts in offline json tx file.
  • Script validation logic to know if enough signatures have been added before assembly.
  • Ability to create new mnemonic wallet (seedphrase).
  • Allows for custom account and index derivation for mnemonic and hardware wallets.
  • Removed CIP95 SPO poll
  • New Catalyst registration option.
    • Prerequisites:
      • cardano-signer created by @gitmachtl. Can be deployed using guild-deploy.sh -s x.
      • catalyst-toolbox compiled from catalyst-core and hosted through Koios share. Automatically downloaded within CNTools if needed.
    • Uses CIP-36 style format with a single delegation
    • Vote keys not derived from 1694' derivation path but cli generated for all types.
    • Ability to verify catalyst registration and check status, both own and external vote pub keys.
  • New Catalyst QR option to display previously generated QR code
  • bump version
  • update changelog
  • tested and ready for alpha merge

@rdlrt rdlrt force-pushed the cntools-multisig branch from ad5178f to 6269f43 Compare June 21, 2024 01:02
@rdlrt rdlrt changed the base branch from alpha to node-9.0.0 July 16, 2024 07:50
@Scitz0 Scitz0 merged commit e722a76 into node-9.0.0 Jul 16, 2024
3 checks passed
@Scitz0 Scitz0 deleted the cntools-multisig branch July 16, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants