Provisioning script updates #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorBenson
approved these changes
May 31, 2024
There was a problem hiding this comment.
LGTM.
I suspect Systemd may be able to be removed from the container. I'll review that separately and if there is no real usage or dependency inside the container open a new PR for testing to further slim down the container, I'll include others in review to make sure I'm not overlooking some special use cases.
As discussed, haproxy or grest might be related to Systemd in container. I'll play with those in looking into possible additional slimming options. |
Scitz0
approved these changes
May 31, 2024
- Only run build dependencies as part of os dependencies when included as flag - Adapt libsodium flag to only use os_dependencies (and include minimal set of dependency there) to make it faster/lighter to deploy libsodium fork on block producing nodes - Include os_dependencies prior to running cardano-hw-cli download (to ensure libusb dependencies are available) - Allow CARDANO_NODE_VERSION to be set as environment variable for those who'd like to test guild-deploy against different node release - Bump CARDANO_NODE_VERSION to 8.9.3 files/docker: - Remove docker stage files - Remove cardano-wallet, as it is no longer relevant in the ecosystem now - for dockerfile_bin, remove tcpping (was unused due to comment), and remove cleanup references for build packages, as they're no longer deployed with `-s p` flag. Also, remove gnupg git from initial run, as they're already included as part of `guild-deploy.sh -s -p` call setup-grest.sh: - Dont use `command -v haproxy` (as the shell isnt always refreshed and /usr/sbin may not be part of $PATH), instead look for /usr/sbin/haproxy to verify if haproxy was already installed - Add haproxy installer dependencies (if guild-deploy is only run with os_dependencies flag, haproxy wouldnt compile in it's current state)
rdlrt
force-pushed
the
guild-deploy-patches
branch
from
ff2a0ae to
ef5ed9b
Compare
rdlrt
added a commit
that referenced
this pull request
May 31, 2024
## Description <!--- Describe your changes --> ### Guild Deploy changes: - Only run build dependencies as part of os dependencies when included as flag - Adapt libsodium flag to only use os_dependencies (and include minimal set of dependency there) to make it faster/lighter to deploy libsodium fork on block producing nodes - Include os_dependencies prior to running cardano-hw-cli download (to ensure libusb dependencies are available) - Allow CARDANO_NODE_VERSION to be set as environment variable for those who'd like to test guild-deploy against different node release - Bump CARDANO_NODE_VERSION to 8.9.3 ### files/docker: - Remove docker stage files - Remove cardano-wallet, as it is no longer relevant in the ecosystem now - for dockerfile_bin, remove tcpping (was unused due to comment), and remove cleanup references for build packages, as they're no longer deployed with `-s p` flag. Also, remove gnupg git from initial run, as they're already included as part of `guild-deploy.sh -s -p` call ### setup-grest.sh: - Dont use `command -v haproxy` (as the shell isnt always refreshed and /usr/sbin may not be part of $PATH), instead look for /usr/sbin/haproxy to verify if haproxy was already installed - Add haproxy installer dependencies (if guild-deploy is only run with os_dependencies flag, haproxy wouldnt compile in it's current state)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Guild Deploy changes:
files/docker:
-s pflag. Also, remove gnupg git from initial run, as they're already included as part ofguild-deploy.sh -s -pcallsetup-grest.sh:
command -v haproxy(as the shell isnt always refreshed and /usr/sbin may not be part of $PATH), instead look for /usr/sbin/haproxy to verify if haproxy was already installed