[container images] Support for pushing testing containers to ghcr.io #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see that 1750 was merged. What is the conflicts that need to be resolved from 1750? |
TrevorBenson
force-pushed
the
feature/ghcr
branch
from
9b77da2 to
ba4a49d
Compare
rdlrt
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a variation on the current logic to always push container images. Production images still go to Docker Hub, while testing images go to GitHub Container Registry and are private except when the container package has permissions granted to github users.
This PR builds on top of PR #1750, as it addressed issue #1748 where a non production cardano version could be the tag of the image while the image actually includes the older production node version from the master branch.
closes #1753