This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Fix 158 #160
Open
Fix 158 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock the scanner view in portrait mode, even when tilting/rotating the device. card-io#158
|
@lkorth Hi Luke. Can you take a look and check if my changes are OK, and hopefully, merge them to the master branch? I am currently working on a project that uses card.io and ran into the problem I described. Right now, I am using my fork, but I would appreciate if I can use the main one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Motorola Moto X Play (Android 6.0.1), Samsung Galaxy Note 8 (Android 7.1.1) and Android emulator (Android 8.0.0). Fix seems to be working as far as keeping the orientation of the overlay layout and scanner guide in portrait mode if EXTRA_LOCK_ORIENTATION is set to true.