Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services): set correct module name #24

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

strieflin
Copy link
Member

No description provided.

@strieflin strieflin requested a review from a team as a code owner November 13, 2024 11:30
@strieflin strieflin requested a review from sbckr November 13, 2024 11:31
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.65%. Comparing base (65a69b4) to head (f310986).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (65a69b4) and HEAD (f310986). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (65a69b4) HEAD (f310986)
java-client 1 0
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #24       +/-   ##
=============================================
- Coverage     80.00%   61.65%   -18.35%     
=============================================
  Files             7        3        -4     
  Lines           170      133       -37     
  Branches         12        0       -12     
=============================================
- Hits            136       82       -54     
- Misses           26       41       +15     
- Partials          8       10        +2     
Flag Coverage Δ
java-client ?
services 61.65% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
services/cmd/catalogue/main.go 0.00% <ø> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65a69b4...f310986. Read the comment docs.

Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strieflin strieflin merged commit eb49d82 into master Nov 13, 2024
10 checks passed
@strieflin strieflin deleted the fix-image-build branch November 13, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants