Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jdk17 and junit5, migrate from hamcrest to assertj #8

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sbckr
Copy link
Member

@sbckr sbckr commented Nov 23, 2021

No description provided.

@sbckr sbckr added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 23, 2021
@sbckr sbckr requested a review from strieflin November 23, 2021 07:17
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #8 (4a1308a) into master (b889feb) will decrease coverage by 0.54%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
- Coverage     85.45%   84.90%   -0.55%     
  Complexity      335      335              
============================================
  Files            61       61              
  Lines          1210     1219       +9     
  Branches         79       78       -1     
============================================
+ Hits           1034     1035       +1     
- Misses          142      151       +9     
+ Partials         34       33       -1     
Impacted Files Coverage Δ
...arbynestack/castor/common/BearerTokenProvider.java 0.00% <0.00%> (ø)
...o/carbynestack/castor/common/CastorServiceUri.java 76.11% <0.00%> (+0.36%) ⬆️
...stack/castor/service/rest/TelemetryController.java 14.28% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b889feb...4a1308a. Read the comment docs.

@sbckr sbckr linked an issue Nov 23, 2021 that may be closed by this pull request
@github-actions
Copy link

This PR has been marked stale because it has been open for 90 days with no activity. It will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 24, 2022
@strieflin strieflin added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 24, 2022
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 26, 2022
@strieflin strieflin marked this pull request as draft January 23, 2023 09:06
@strieflin strieflin removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to JDK17 and JUnit 5, Migrate from Hamcrest to AssertJ
2 participants