feat(amphora-service)!: add opa client and service #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Becker <[email protected]>
sbckr
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
============================================
+ Coverage 90.04% 90.07% +0.02%
- Complexity 348 397 +49
============================================
Files 49 59 +10
Lines 1326 1471 +145
Branches 70 78 +8
============================================
+ Hits 1194 1325 +131
- Misses 80 93 +13
- Partials 52 53 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Sebastian Becker <[email protected]>
Signed-off-by: Sebastian Becker <[email protected]>
Signed-off-by: Sebastian Becker <[email protected]>
Signed-off-by: Sebastian Becker <[email protected]>
Signed-off-by: Sebastian Becker <[email protected]>
Signed-off-by: Sebastian Becker <[email protected]>
sbckr
commented
Dec 16, 2024
There was a problem hiding this comment.
check empty line at end of file
| public static final String SECRET_WITH_ID_EXISTS_EXCEPTION_MSG = | ||
| "A secret with the given id already exists."; | ||
| "A secret with the given id already exists."; |
There was a problem hiding this comment.
verify pre-commit formatting
strieflin
requested changes
Dec 16, 2024
|
|
||
| opa: | ||
| defaultPolicyPackage: "carbynestack.def" | ||
| endpoint: "http://opa.default.svc.cluster.local:8081/" |
| OpaResult.class) | ||
| .isAllowed(); | ||
| } catch (CsHttpClientException e) { | ||
| log.error("Error occurred while evaluating OPA policy package: {}", e.getMessage()); |
There was a problem hiding this comment.
Logging the full exception and not only the message might provide more helpful debugging information in case something goes wrong.
| @@ -13,14 +13,17 @@ spring.datasource.username=${POSTGRESQL_USERNAME} | |||
| spring.datasource.password=${POSTGRESQL_PASSWORD} | |||
| spring.jpa.database=postgresql | |||
| spring.jpa.database-platform=org.hibernate.dialect.PostgreSQLDialect | |||
| spring.jpa.hibernate.connection.autocommit=true | |||
| spring.jpa.hi.hibernate.connection.autocommit=true | |||
| } | ||
|
|
||
| @Test | ||
| void givenNoTokenProvided_whenExtractSubject_thenThrowUnauthorizedException() throws UnauthorizedException { |
There was a problem hiding this comment.
Shouldn't his be givenInvalidToken or something alike?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.