feat(coachmark): Add default opening for not-stacked coachmarks #6516
+39
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
gcattan
changed the title
gcattan
changed the title
|
I have read the DCO document and I hereby sign the DCO. |
gcattan
requested review from
AlexanderMelox and
devadula-nandan
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6516 +/- ##
==========================================
+ Coverage 79.85% 79.87% +0.01%
==========================================
Files 394 394
Lines 12877 12878 +1
Branches 4258 4260 +2
==========================================
+ Hits 10283 10286 +3
+ Misses 2594 2592 -2
|
devadula-nandan
requested changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5709
Add a property to open the coachmark by default.
What did you change?
Add the property
isOpenByDefaultto the coachmark, which applies in the case the coachmark is not a stacked coachmark.How did you test and verify your work?
Added two tests to the suite:
isOpenByDefaultistrueisOpenByDefaultisfalse.