Decorator Modal
#18101
Merged
Decorator Modal
#18101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18101 +/- ##
==========================================
+ Coverage 82.21% 82.22% +0.01%
==========================================
Files 404 404
Lines 14200 14210 +10
Branches 4509 4523 +14
==========================================
+ Hits 11674 11684 +10
Misses 2363 2363
Partials 163 163 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ariellalgilmore
approved these changes
Nov 19, 2024
Co-authored-by: Ariella Gilmore <[email protected]>
annawen1
approved these changes
Nov 19, 2024
tay1orjones
approved these changes
Nov 20, 2024
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
* feat: added decorator * fix: fixed styles * fix: fixed ai style * test: fixed tests * fix: delete datepicker decorator example * fix: fixed styles * fix: fixed styles * fix: fixed styles * fix: yarn format * fix: merge style with composedmodal * fix: fixed revert icon * fix: removed revert from stories * fix: removed modal stories * Update packages/styles/scss/components/modal/_modal.scss Co-authored-by: Ariella Gilmore <[email protected]> --------- Co-authored-by: Ariella Gilmore <[email protected]>
Merged
via the queue into
carbon-design-system:main
with commit Nov 20, 2024
d5bc886
40 checks passed
|
Hey there! v11.71.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17993
Added decorator to
ModalChangelog
New
decoratorprop added toModalcomponentChanged
slugpropblock-sizeto the style to fix the alignmentTesting / Reviewing
Make sure the
Modalstill work as expected and the one withdecoratoralso works fineDelete
ModalwithTooltipDelete
DatepickerwithTooltip