Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag): new decorator prop #18077

Merged

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Nov 14, 2024

Closes #18002

Updates Tag to include new decorator prop

Changelog

New

  • new decorator prop, classes, and styles

Changed

  • deprecated slug prop
  • update rendering slug to render the decorator component but still set the size if it's an AILabel
  • updated tests
  • note I only updated Tag and Dismissible Tag and not the Tag using the filter prop since it's deprecated

Testing / Reviewing

Check tag with AILabel storybook ( i think the tooltip still looks a little odd, but maybe something to fix once people start using it and we can have design take a better look)

TODO:

  • remove tag with tooltip before merging!

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit bd70094
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/673e26ca24c2af0008c01eae
😎 Deploy Preview https://deploy-preview-18077--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bd70094
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/673e26ca3ba7800008a4e530
😎 Deploy Preview https://deploy-preview-18077--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit bd70094
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/673e26caf1b283000828ac65
😎 Deploy Preview https://deploy-preview-18077--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (b53f566) to head (bd70094).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18077      +/-   ##
==========================================
+ Coverage   82.29%   82.33%   +0.03%     
==========================================
  Files         404      404              
  Lines       14276    14297      +21     
  Branches     4531     4552      +21     
==========================================
+ Hits        11749    11771      +22     
+ Misses       2365     2364       -1     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ariellalgilmore ariellalgilmore marked this pull request as ready for review November 18, 2024 16:02
@ariellalgilmore ariellalgilmore requested review from a team as code owners November 18, 2024 16:02
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tay1orjones tay1orjones added this pull request to the merge queue Nov 20, 2024
Merged via the queue into carbon-design-system:main with commit 633ab3c Nov 20, 2024
40 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.71.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator: Tag
3 participants