-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed hover on multiselect #17944
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17944 +/- ##
=======================================
Coverage 82.14% 82.14%
=======================================
Files 404 404
Lines 14117 14117
Branches 4434 4404 -30
=======================================
Hits 11597 11597
+ Misses 2359 2358 -1
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
It looks good to me but I think it's better to take a design review on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guidari Looking good! Just two small things:
MultiSelect and Filterable MultiSelect
- The border around the tag is not the correct color. The design spec says it should be color token
$border-subtle
.
MultiSelect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the cursor is updated 👍
Thanks @laurenmrice ! My bad, I didn't see the design spec down there in the issue 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks Gui!
5b3ad47
Hey there! v11.71.0 was just released that references this issue/PR. |
Closes #17820
Setting background-color to transparent when
Multiselect
is set toreadOnly
Testing / Reviewing
Multiselect
orFilterableMultiselect
toreadOnly