Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed hover on multiselect #17944

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Nov 1, 2024

Closes #17820

Setting background-color to transparent when Multiselect is set to readOnly

Testing / Reviewing

  • Go to playground and set Multiselect or FilterableMultiselect to readOnly

@guidari guidari requested a review from a team as a code owner November 1, 2024 13:39
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 803f673
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6735ec84050ee600089bd4cd
😎 Deploy Preview https://deploy-preview-17944--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 803f673
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6735ec847429320008e60b6b
😎 Deploy Preview https://deploy-preview-17944--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 803f673
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6735ec84a063f00008e51554
😎 Deploy Preview https://deploy-preview-17944--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (ad23c63) to head (803f673).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17944   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files         404      404           
  Lines       14117    14117           
  Branches     4434     4404   -30     
=======================================
  Hits        11597    11597           
+ Misses       2359     2358    -1     
- Partials      161      162    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@preetibansalui
Copy link
Contributor

It looks good to me but I think it's better to take a design review on this one.

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guidari Looking good! Just two small things:

MultiSelect and Filterable MultiSelect

  • The border around the tag is not the correct color. The design spec says it should be color token $border-subtle.

MultiSelect

  • On the "Playground" story of MultiSelect, when the readonly prop is set to true, when hovering over the field and tag, there are still areas where the mouse cursor turns to a pointer instead of the arrow. It should always be the arrow in the readonly state.
    Nov-05-2024 15-14-19

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the cursor is updated 👍

@guidari
Copy link
Contributor Author

guidari commented Nov 6, 2024

@guidari Looking good! Just two small things:

MultiSelect and Filterable MultiSelect

  • The border around the tag is not the correct color. The design spec says it should be color token $border-subtle.

Thanks @laurenmrice ! My bad, I didn't see the design spec down there in the issue 😅

@guidari guidari requested a review from laurenmrice November 6, 2024 14:18
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks Gui!

@guidari guidari added this pull request to the merge queue Nov 19, 2024
Merged via the queue into carbon-design-system:main with commit 5b3ad47 Nov 19, 2024
39 of 40 checks passed
@guidari guidari deleted the 17820-multiselect branch November 19, 2024 15:52
@carbon-automation
Copy link
Contributor

Hey there! v11.71.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Readonly state in Multiselect and FilterableMultiselect has hover interaction on the close button.
5 participants