-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add TypeScript types to inlinecheckbox #17729
refactor: Add TypeScript types to inlinecheckbox #17729
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17729 +/- ##
==========================================
- Coverage 82.10% 82.09% -0.01%
==========================================
Files 404 404
Lines 14107 14117 +10
Branches 4426 4434 +8
==========================================
+ Hits 11582 11590 +8
- Misses 2363 2364 +1
- Partials 162 163 +1 ☔ View full report in Codecov by Sentry. |
735bddc
to
dcab08e
Compare
dcab08e
to
39efa95
Compare
It was required before it was deprecated. We can't make it's replacement ( |
ad23c63
Closes #17677
Added Tpyescript types to inlinecheckbox
I am curious why ariaLabel is marked both deprecated and required
Changelog
New
Changed
Removed
Testing / Reviewing
check the deploy preview and make sure no console errors are present