Added tests for FluidTimePicker #17541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17541 +/- ##
==========================================
+ Coverage 76.95% 77.14% +0.18%
==========================================
Files 408 409 +1
Lines 13979 14024 +45
Branches 4291 4359 +68
==========================================
+ Hits 10758 10819 +61
+ Misses 3048 3035 -13
+ Partials 173 170 -3 ☔ View full report in Codecov by Sentry. |
tay1orjones
requested changes
Sep 23, 2024
| </FluidTimePicker> | ||
| ); | ||
|
|
||
| fireEvent.click(screen.getByRole('textbox')); |
There was a problem hiding this comment.
Could this use userEvent instead? It more realistically simulates the interaction, see here
Gururajj77
changed the title
kennylam
approved these changes
Oct 2, 2024
tay1orjones
approved these changes
Oct 8, 2024
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Oct 8, 2024
348b3b5
36 checks passed
|
Hey there! v11.68.0 was just released that references this issue/PR. |
annawen1
pushed a commit
to annawen1/carbon
that referenced
this pull request
Oct 11, 2024
* test: added tests for FluiTimePicker * fix: changed from fireevent to userevent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17516
Added tests for FluiTimePicker
Testing / Reviewing