-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(10343): Adds support for 'required' prop on RadioTile & TileGroup #16237
fix(10343): Adds support for 'required' prop on RadioTile & TileGroup #16237
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
From the original issue:
Should |
This makes sense, only concern is the proper usage of the HTML element/definition because |
@2nikhiltom I wouldn't apply the |
@tw15egan if we add required to |
Yeah I think it would be good for consistency |
I have made changes to accommodate the above concern. Now I will created a separate issue for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I pushed one update here adding tests for the required functionality on TileGroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
8bb54fa
Closes #10343
Adds support for '
required
' prop onRadioTile
Adds support for '
required
' prop onTileGroup
New
RadioTile
supports 'required
' prop and attaches it to underlyingInput
Adds new
TestCase
to verify this functionalityTileGroup
supports 'required
' prop and attaches it to childrenRadioTile
Changed
RadioTile
acceptsrequired
propPublicAPI
snapshot updated with 'required' boolean attributeThe
required
attribute has to be specified only on everyTileGroup
instead of on every childRadioTile
Testing / Reviewing
(Take pull of this PR and update any one of the storybook example with below code )