Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 10502-radio-button-misalignment-bug #15435

Conversation

riddhybansal
Copy link
Contributor

@riddhybansal riddhybansal commented Dec 20, 2023

Closes #10502

The error message in the radio button overlaps the label.

Changelog

New

  • Changed some styles

Testing / Reviewing

@riddhybansal riddhybansal requested a review from a team as a code owner December 20, 2023 14:24
Copy link
Contributor

github-actions bot commented Dec 20, 2023

DCO Assistant Lite bot All contributors have signed the DCO.

@riddhybansal
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 80d288b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65d3ab2be83469000855c2d4
😎 Deploy Preview https://deploy-preview-15435--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in chrome and firefox, but safari still covers up the label.

image

This comment mentions the input dimensions could be something to look into, have you explored that angle compared with the margin approach you've got here so far?

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in chrome, firefox, and safari on macOS - everything looks great. Before we can merge the test story should be deleted. Once removed, this is ready to merge. I think removing it should also fix the merge conflict.

@tay1orjones tay1orjones added this pull request to the merge queue Feb 19, 2024
Merged via the queue into carbon-design-system:main with commit bac2f4f Feb 19, 2024
21 checks passed
@brunnerh
Copy link

Checkbox still has this issue as mentioned in my comment from #10002, by the way.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Native radio button validation errors are misaligned
5 participants