-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 10502-radio-button-misalignment-bug #15435
fix: 10502-radio-button-misalignment-bug #15435
Conversation
DCO Assistant Lite bot All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in chrome and firefox, but safari still covers up the label.
This comment mentions the input dimensions could be something to look into, have you explored that angle compared with the margin approach you've got here so far?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in chrome, firefox, and safari on macOS - everything looks great. Before we can merge the test story should be deleted. Once removed, this is ready to merge. I think removing it should also fix the merge conflict.
bac2f4f
Checkbox still has this issue as mentioned in my comment from #10002, by the way. |
Closes #10502
The error message in the radio button overlaps the label.
Changelog
New
Testing / Reviewing