Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Checkbox): add positioning to checkbox input for native validation alignment #10142

Merged

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Nov 19, 2021

Closes #10002

Changelog

  • even thought checkbox input isn't visible, this aligns it to the visible checkbox so that native browser validation will be aligned
  • add validation example on checkbox stories (can remove this once approved)

Testing / Reviewing

View React deploy preview:

  1. go to checkbox validation story
  2. don't check the box
  3. click the button
  4. browser validation should align below checkbox

@jnm2377 jnm2377 requested a review from a team as a code owner November 19, 2021 03:40
@netlify
Copy link

netlify bot commented Nov 19, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: e7a1d55

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61a544e9ea0d6a0007f15cf0

😎 Browse the preview: https://deploy-preview-10142--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Nov 19, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e7a1d55

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61a544e9ba14ae000734509f

😎 Browse the preview: https://deploy-preview-10142--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Nov 19, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: e7a1d55

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61a544e9788c18000845bde8

😎 Browse the preview: https://deploy-preview-10142--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 56cec53 into carbon-design-system:main Nov 29, 2021
@abbeyhrt abbeyhrt mentioned this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Native Checkbox validation errors are misaligned
4 participants