Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate straight quotes ( " and ' ) into “curly” quotes #721

Open
2 tasks
alisonjoseph opened this issue May 13, 2022 · 4 comments · May be fixed by #1450
Open
2 tasks

Translate straight quotes ( " and ' ) into “curly” quotes #721

alisonjoseph opened this issue May 13, 2022 · 4 comments · May be fixed by #1450
Labels
role: dev 🤖 status: deferred 🔜

Comments

@alisonjoseph
Copy link
Member

alisonjoseph commented May 13, 2022 •
edited by mattrosno
Loading

https://github.com/silvenon/remark-smartypants

Smartypants automatically translates straight quotes ( " and ' ) into “curly” quote HTML entities

Consider doing this "in-house" if simple enough to not depend on a code package that hasn't received wide-spread adoption.

#721 (comment)
@jharvey10
Copy link
Contributor

Just checked out the package. A couple notes on it:

  1. The package has a very low amount of weekly downloads, which is concerning from a maintenance and battle-hardening perspective.
  2. This seems like something that should be handled by the markdown content developer themself; They should be using the appropriate text characters for their language and localization without us intervening.

@mattrosno
Copy link
Member

"Test 123". I'm testing.

@mattrosno mattrosno changed the title Add smartypants remark plugin Translate straight quotes ( " and ' ) into “curly” quotes May 16, 2022
@mattrosno
Copy link
Member

Hey team! Please add your planning poker estimate with ZenHub @alisonjoseph @andreancardona @francinelucca @jdharvey-ibm

@mattrosno mattrosno mentioned this issue Aug 1, 2022
Closed
3 tasks
@mattrosno mattrosno mentioned this issue Aug 15, 2022
Closed
This was referenced Sep 15, 2022
Closed
Closed
This was referenced Sep 29, 2022
Closed
Open
Closed
@francinelucca francinelucca self-assigned this Oct 21, 2022
@francinelucca francinelucca linked a pull request Oct 21, 2022 that will close this issue
Add smartypants #1450
Draft
1 task
@francinelucca
Copy link
Collaborator

Confirmed no sonarcloud alerts on the regex in https://github.com/silvenon/remark-smartypants/blob/master/index.js (what https://github.com/retextjs/retext-smartypants uses in the background) so we're good to move forward!
image
image

@mattrosno mattrosno mentioned this issue Oct 21, 2022
Open
1 task
francinelucca added a commit that referenced this issue Oct 21, 2022
@francinelucca
feat(mdx-processor): add smartypants
627ee0f 
Closes #721
francinelucca added a commit that referenced this issue Oct 21, 2022
@francinelucca
feat(web-app): add smartypants
a5467a5 
Closes #721
@francinelucca francinelucca linked a pull request Oct 21, 2022 that will close this issue
Draft
1 task
@francinelucca francinelucca removed their assignment Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
role: dev 🤖 status: deferred 🔜
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add smartypants carbon-design-system/carbon-platform
4 participants
@mattrosno @alisonjoseph @francinelucca @jharvey10