Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): svelte packaging #1258

Merged
merged 4 commits into from
Jan 27, 2022
Merged

fix(build): svelte packaging #1258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b17d50
fix Svelte packaging
benmccann Jan 1, 2022
afdc256
Remove Rollup config for Svelte package
benmccann Jan 1, 2022
e8bcaf5
remove rollup from build file
benmccann Jan 2, 2022
7771eec
revert change to core package
benmccann Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default {
input: './src/index.ts',
output: {
file: `./dist/bundle.js`,
format: 'umd',
format: 'cjs',
name: 'Charts',
globals: {
'd3-scale': 'd3Scale',
Expand Down
6 changes: 3 additions & 3 deletions packages/svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"name": "@carbon/charts-svelte",
"version": "0.54.0",
"description": "Carbon charting components for Svelte",
"main": "./bundle.js",
"module": "./index.js",
"svelte": "./src/index.js",
"type": "module",
"main": "./index.js",
benmccann marked this conversation as resolved.
Show resolved Hide resolved
"svelte": "./index.js",
benmccann marked this conversation as resolved.
Show resolved Hide resolved
"types": "./types/index.d.ts",
"scripts": {
"start": "yarn run storybook",
Expand Down
17 changes: 0 additions & 17 deletions packages/svelte/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,6 @@ import resolve from "rollup-plugin-node-resolve";
import svelte from "rollup-plugin-svelte";

export default [
{
input: "./src/index.js",
output: {
file: "./dist/bundle.js",
format: "umd",
name: "ChartsSvelte",
globals: {
"@carbon/charts": "Charts"
}
},
plugins: [
svelte(),
resolve(),
terser()
],
external: ["svelte", "@carbon/charts"]
},
{
input: "./src/index.js",
output: {
Expand Down