Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update traffic rule names in fiber config #290

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Update traffic rule names in fiber config #290

merged 1 commit into from
Nov 21, 2022

Conversation

krithika369
Copy link
Collaborator

@krithika369 krithika369 commented Nov 20, 2022 •
edited
Loading

Updating the Fiber config builder to use the user-defined traffic rule name as opposed to traffic-split-X. This will help propagate the user-defined names to the custom metric traffic_rule label introduced in #280.

@krithika369 krithika369 requested a review from a team November 21, 2022 02:57
@krithika369 krithika369 merged commit 695bcf2 into caraml-dev:main Nov 21, 2022
@krithika369 krithika369 deleted the fix_traffic_rule_name branch November 21, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryyylim terryyylim terryyylim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krithika369 @terryyylim