Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor inference schema #543

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Refactor inference schema #543

merged 6 commits into from
Mar 1, 2024

Conversation

khorshuheng
Copy link
Collaborator

@khorshuheng khorshuheng commented Feb 21, 2024 •
edited
Loading

Description

Modifications

  • Add session_id and row_id column to the InferenceSchema class.
  • Use actual_score instead of actual_label for binary classification
  • Remove prediction group id attribute from ModelPredictionOutput, since the prediction group id is equivalent to the session id.
  • Remove prediction id column since Arize doesn't require the column name to be the same for both prediction and ground truth ingestion.
  • Add optional feature orders column to support standard model use case

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

@khorshuheng khorshuheng added the enhancement New feature or request label Feb 21, 2024
@ghost
Copy link

ghost commented Feb 21, 2024 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@khorshuheng khorshuheng force-pushed the refactor-inference-schema branch 7 times, most recently from e97a44b to df7cbf5 Compare February 23, 2024 02:32
@khorshuheng khorshuheng changed the title Draft: refactor inference schema Refactor inference schema Feb 26, 2024
@khorshuheng khorshuheng force-pushed the refactor-inference-schema branch 2 times, most recently from 750dea0 to 839d620 Compare February 28, 2024 06:57
tiopramayudi
tiopramayudi approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@tiopramayudi tiopramayudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiopramayudi
Copy link
Contributor

can you update the documentation also?

@khorshuheng khorshuheng force-pushed the refactor-inference-schema branch from faba901 to 643f71e Compare March 1, 2024 05:57
@khorshuheng khorshuheng merged commit 66da93e into main Mar 1, 2024
32 checks passed
@khorshuheng khorshuheng deleted the refactor-inference-schema branch March 1, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiopramayudi tiopramayudi tiopramayudi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khorshuheng @tiopramayudi