Draft: bug: fix pydantic error for batch prediction job executor #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
force-pushed
the
fix-pydantic-error-in-batch-executor
branch
from
ad5511d to
ce3ba5f
Compare
khorshuheng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #535 , we fixed the issue with pydantic schema generation by preloading the Pyfunc model classes. This was done for the driver script for batch prediction job and the start up script for real time Pyfunc model, but did not include merlinpyspark/model.py, which is called within the spark executor.
Modifications
Preload the pyfunc model for merlinpyspark/model.py
Tests
Checklist
Release Notes