feat: reuse the same bigquery table for multiple model versions for Arize BQ Sink #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
changed the title
tiopramayudi
reviewed
Feb 5, 2024
khorshuheng
force-pushed
the
general-bq-sink
branch
from
e461f47 to
fb8a77d
Compare
tiopramayudi
approved these changes
Feb 15, 2024
khorshuheng
force-pushed
the
general-bq-sink
branch
from
fb8a77d to
d54445e
Compare
…rize BigQuery Sink
khorshuheng
force-pushed
the
general-bq-sink
branch
from
d54445e to
f4ec3fe
Compare
leonlnj
pushed a commit
that referenced
this pull request
Feb 20, 2024
…rize BQ Sink (#531) <!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> # Description <!-- Briefly describe the motivation for the change. Please include illustrations where appropriate. --> The current sink create a new bigquery table per model version. This makes it harder to implement Arize ground truth ingestion, because the ground truth provided by the users are typically model version agnostic. # Modifications <!-- Summarize the key code changes. --> - A single table will be used per model id, rather than model version - A new column, model_version, is added. - session id and row id are used in favor of prediction id as the concept of prediction id in Arize differs from Merlin # Tests <!-- Besides the existing / updated automated tests, what specific scenarios should be tested? Consider the backward compatibility of the changes, whether corner cases are covered, etc. Please describe the tests and check the ones that have been completed. Eg: - [x] Deploying new and existing standard models - [ ] Deploying PyFunc models --> # Checklist - [ ] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [ ] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes <!-- Does this PR introduce a user-facing change? If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current sink create a new bigquery table per model version. This makes it harder to implement Arize ground truth ingestion, because the ground truth provided by the users are typically model version agnostic.
Modifications
Tests
Checklist
Release Notes