Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add protocol default value for version and model endpoints & relax supported enum in OpenAPI #529

Closed
wants to merge 3 commits into from
Closed

fix: Add protocol default value for version and model endpoints & relax supported enum in OpenAPI #529

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
012fb02
Add default value for protocol in version endpoint and model endpoints
tiopramayudi Feb 2, 2024
ef8f784
Add down script that do nothing
tiopramayudi Feb 2, 2024
a7814e0
Relax the enum for protocol and deployment mode to accept empty string
tiopramayudi Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions db-migrations/37_update_protocol_default.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
-- Updating default protocol for version endpoints
update
version_endpoints
set protocol = 'HTTP_JSON'
where protocol is null or protocol = '';


-- Updating default protocol for model endpoints
update
model_endpoints
set protocol = 'HTTP_JSON'
where protocol is null or protocol = '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super tiny nit but can we have the SQL commands in capital letters for consistency with other migration scripts (and for very slightly better readability) 😅 Thanks! 🙏

Loading