-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Incorrect request body for create and patch version #522
Conversation
00b4fd6
to
ebce098
Compare
…d as payload field
Seems like the deserialization failed because fields in RegressionOutput is a subset of the fields in BinaryClassification. Since extra fields are ignored, both passed the validation test and result in more than one match. |
I checked the swagger schema. Are we missing the mapping here?
|
this is due to not using discriminator lookup, hence they try to deserialize to all possible schema |
Description
Previously in this #518 we introduce CRUD API for model schema, also changed the version schema that aim to update model schema during version creation. While CRUID API is working correctly, create model version with model schema info is not working properly, due to the request body type that is used for the controller is not
Version
butVersionPost
. Hence this PR try to fix that issueModifications
api/api/version_api.go
-> Update the model version creation by supplying model schema data fromVersionPost
toVersion
api/models/version.go
-> IncludingModelSchema
field forVersionPost
andVersionPatch
struct to supply model schema info during model version creation or patchpython/sdk/merlin/model_schema.py
-> Addoutput_class
field to model prediction outputpython/sdk/test/integration_test.py
-> Add new integration test for model schemaTests
Checklist
Release Notes