Uninstall merlin-sdk before installing pyfunc/batch dependencies #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krithika369
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If user has a direct or indirect dependency on merlin-sdk on their pyfunc or batch job's conda.yaml, that merlin-sdk version is the one that will be used to run the pyfunc or batch job, ignoring the local merlin-sdk. By uninstalling it before installing the pyfunc or batch job dependencies, we make sure to always use the local merlin-sdk version.
Which issue(s) this PR fixes:
Fixes pyfunc/batch job running old version of merlin
Does this PR introduce a user-facing change?:
Checklist