Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin caraml-upi-protos>=0.3.4 #506

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Pin caraml-upi-protos>=0.3.4 #506

merged 1 commit into from
Dec 14, 2023

Conversation

ariefrahmansyah
Copy link
Contributor

What this PR does / why we need it:

pyfunc-server's converter needs 'prediction_log_pb2' from 'caraml.upi.v1' which only available in >=0.3.4

Which issue(s) this PR fixes:

Fixes error: ImportError: cannot import name 'prediction_log_pb2' from 'caraml.upi.v1' if user use old version of caraml-upi-protos

Does this PR introduce a user-facing change?:

NONE

Checklist

  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduce API changes

@ghost
Copy link

ghost commented Dec 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@tiopramayudi tiopramayudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix ,arief 🙏

@ariefrahmansyah ariefrahmansyah merged commit 337cdd7 into main Dec 14, 2023
28 checks passed
@ariefrahmansyah ariefrahmansyah deleted the pin-caraml-upi-protos branch December 14, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants