Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Add additional check to allow update endpoint requests without deployment type specified #474

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Oct 19, 2023

What this PR does / why we need it:
As a follow up to #455 and #466, this tiny change to the update endpoint endpoint allows requests that do not specify a deployment type to avoid the check that checks for different deployment types between a deployed endpoint and the new endpoint configuration. What will instead happen if a deployment type isn't specified is that the existing deployed endpoint's deployment type will be used.

The main change is just the addition of another boolean condition, but there's a unit test that I added which is just an almost exact copy of another unit test case.

Which issue(s) this PR fixes:
Fixes #

Does this PR introduce a user-facing change?:

NONE

Checklist

  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduce API changes

@deadlycoconuts deadlycoconuts added the bug Something isn't working label Oct 19, 2023
@deadlycoconuts deadlycoconuts self-assigned this Oct 19, 2023
@ghost
Copy link

ghost commented Oct 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@deadlycoconuts deadlycoconuts marked this pull request as ready for review October 19, 2023 10:20
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Zi Yi for quick fix!

@ariefrahmansyah ariefrahmansyah merged commit 7a32f96 into main Oct 19, 2023
42 checks passed
@ariefrahmansyah ariefrahmansyah deleted the fix_deployment_type_change_check branch October 19, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants