Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update scale to zero limitation docs #472

Merged
merged 4 commits into from
Oct 16, 2023
Merged

[Docs] Update scale to zero limitation docs #472

merged 4 commits into from
Oct 16, 2023

Conversation

tkpd-hafizhan
Copy link
Contributor

@tkpd-hafizhan tkpd-hafizhan commented Oct 12, 2023 •
edited
Loading

What this PR does / why we need it:

  • Update Limitation Docs + Proof reading using ChatGPT

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Checklist

  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduce API changes

@tkpd-hafizhan tkpd-hafizhan changed the title update scale to zero limitation docs [Docs] Update scale to zero limitation docs Oct 12, 2023
@ghost
Copy link

ghost commented Oct 12, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

krithika369
krithika369 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@krithika369 krithika369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update, @tkpd-hafizhan !

@tkpd-hafizhan
Copy link
Contributor Author

tkpd-hafizhan commented Oct 13, 2023 •
edited
Loading

Will merge after testing Complete

@tkpd-hafizhan tkpd-hafizhan merged commit 91adb71 into main Oct 16, 2023
42 checks passed
@tkpd-hafizhan tkpd-hafizhan deleted the update-docs-limitation branch October 16, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krithika369 krithika369 krithika369 approved these changes

@ariefrahmansyah ariefrahmansyah Awaiting requested review from ariefrahmansyah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkpd-hafizhan @krithika369 @ariefrahmansyah