fix typos

caraml-dev · Oct 1, 2023 · f230bda · f230bda
1 parent 3740c6e
commit f230bda
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/python/sdk/merlin/client.py b/python/sdk/merlin/client.py
@@ -280,14 +280,14 @@ def standard_transformer_simulate(
         headers: dict,
         config: dict,
         model_prediction_config: dict,
-        protocol: Protocol,
+        protocol: Protocol = Protocol.HTTP_JSON,
     ):
         request = StandardTransformerSimulationRequest(
             payload=payload,
             headers=headers,
             config=config,
             model_prediction_config=model_prediction_config,
-            protocol="HTTP_JSON",
+            protocol=protocol,
         )
 
         return self._standard_transformer_api.standard_transformer_simulate_post(

diff --git a/python/sdk/merlin/transformer.py b/python/sdk/merlin/transformer.py
@@ -113,7 +113,7 @@ def _transformer_config_env_var(self):
     def simulate(
         self,
         payload: Dict,
-        headers: Dict = None,
+        headers: Dict = Dict,
         model_prediction_config: Dict = None,
         protocol: Protocol = Protocol.HTTP_JSON,
         exclude_tracing: bool = False,

diff --git a/python/sdk/test/integration_test.py b/python/sdk/test/integration_test.py
@@ -1166,7 +1166,7 @@ def test_standard_transformer_simulate(integration_test_url, use_google_oauth):
     resp_wo_tracing = transformer.simulate(payload=payload, exclude_tracing=True)
     resp_w_tracing = transformer.simulate(payload=payload, exclude_tracing=False)
 
-    resp_valid_wo_tracing = {
+    exp_resp_valid_wo_tracing = {
         "response": {
             "instances": {
                 "columns": [
@@ -1187,7 +1187,7 @@ def test_standard_transformer_simulate(integration_test_url, use_google_oauth):
         }
     }
 
-    resp_valid_w_tracing = {
+    exp_resp_valid_w_tracing = {
         "response": {
             "instances": {
                 "columns": [
@@ -1444,6 +1444,6 @@ def test_standard_transformer_simulate(integration_test_url, use_google_oauth):
     assert "response" in resp_wo_tracing.keys()
     assert "response" in resp_w_tracing.keys()
     assert "operation_tracing" not in resp_wo_tracing.keys()
-    assert "operation_tracing" in resp_wo_tracing.keys()
-    assert resp_wo_tracing == resp_valid_wo_tracing
-    assert resp_w_tracing == resp_valid_w_tracing
+    assert "operation_tracing" in resp_w_tracing.keys()
+    assert resp_wo_tracing == exp_resp_valid_wo_tracing
+    assert resp_w_tracing == exp_resp_valid_w_tracing