Skip to content

Commit

Permalink
Fix unspecified model_observability parameter on sdk
Browse files Browse the repository at this point in the history
  • Loading branch information
tiopramayudi committed Dec 2, 2024
1 parent c2bcce2 commit af2e8b6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion api/models/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func NewService(model *Model, version *Version, modelOpt *ModelOption, endpoint
AutoscalingPolicy: endpoint.AutoscalingPolicy,
Protocol: endpoint.Protocol,
CurrentIsvcName: endpoint.InferenceServiceName,
EnabledModelObservability: endpoint.EnableModelObservability,
EnabledModelObservability: endpoint.IsModelMonitoringEnabled(),
ModelSchema: version.ModelSchema,
PredictorUPIOverHTTPEnabled: predictorUPIOverHTTPEnabled(endpoint.Transformer, endpoint.Protocol),
}
Expand Down
2 changes: 2 additions & 0 deletions python/sdk/merlin/fluent.py
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,7 @@ def deploy(
autoscaling_policy,
protocol,
enable_model_observability,
model_observability
)

return _merlin_client.deploy( # type: ignore
Expand All @@ -432,6 +433,7 @@ def deploy(
autoscaling_policy,
protocol,
enable_model_observability,
model_observability
)


Expand Down

0 comments on commit af2e8b6

Please sign in to comment.