Update unit test

caraml-dev · Dec 15, 2023 · 1584024 · 1584024
1 parent ae831fe
commit 1584024
Showing 1 changed file with 34 additions and 29 deletions.
diff --git a/api/pkg/imagebuilder/imagebuilder_test.go b/api/pkg/imagebuilder/imagebuilder_test.go
@@ -110,6 +110,8 @@ var (
 		"--use-new-run",
 	}
 
+	defaultSupportedPythonVersions = []string{"3.8.*", "3.9.*", "3.10.*"}
+
 	config = Config{
 		BuildNamespace: testBuildNamespace,
 		BaseImage: cfg.BaseImageConfig{
@@ -125,7 +127,7 @@ var (
 		Environment:             testEnvironmentName,
 		KanikoImage:             "gcr.io/kaniko-project/executor:v1.1.0",
 		KanikoAdditionalArgs:    defaultKanikoAdditionalArgs,
-		SupportedPythonVersions: []string{"3.8.*", "3.9.*", "3.10.*"},
+		SupportedPythonVersions: defaultSupportedPythonVersions,
 		DefaultResources: cfg.ResourceRequestsLimits{
 			Requests: cfg.Resource{
 				CPU:    "500m",
@@ -164,7 +166,7 @@ var (
 		Environment:             testEnvironmentName,
 		KanikoImage:             "gcr.io/kaniko-project/executor:v1.1.0",
 		KanikoAdditionalArgs:    defaultKanikoAdditionalArgs,
-		SupportedPythonVersions: []string{"3.8.*", "3.9.*", "3.10.*"},
+		SupportedPythonVersions: defaultSupportedPythonVersions,
 		DefaultResources: cfg.ResourceRequestsLimits{
 			Requests: cfg.Resource{
 				CPU:    "500m",
@@ -557,14 +559,15 @@ func TestBuildImage(t *testing.T) {
 					BuildContextSubPath: "python/pyfunc-server",
 					DockerfilePath:      "./Dockerfile",
 				},
-				DockerRegistry:       testDockerRegistry,
-				BuildTimeoutDuration: timeout,
-				ClusterName:          "my-cluster",
-				GcpProject:           "test-project",
-				Environment:          testEnvironmentName,
-				KanikoImage:          "gcr.io/kaniko-project/executor:v1.1.0",
-				KanikoAdditionalArgs: defaultKanikoAdditionalArgs,
-				DefaultResources:     config.DefaultResources,
+				DockerRegistry:          testDockerRegistry,
+				BuildTimeoutDuration:    timeout,
+				ClusterName:             "my-cluster",
+				GcpProject:              "test-project",
+				Environment:             testEnvironmentName,
+				KanikoImage:             "gcr.io/kaniko-project/executor:v1.1.0",
+				KanikoAdditionalArgs:    defaultKanikoAdditionalArgs,
+				SupportedPythonVersions: defaultSupportedPythonVersions,
+				DefaultResources:        config.DefaultResources,
 				NodeSelectors: map[string]string{
 					"cloud.google.com/gke-nodepool": "image-building-job-node-pool",
 				},
@@ -687,14 +690,15 @@ func TestBuildImage(t *testing.T) {
 					BuildContextSubPath: "python/pyfunc-server",
 					DockerfilePath:      "./Dockerfile",
 				},
-				DockerRegistry:       testDockerRegistry,
-				BuildTimeoutDuration: timeout,
-				ClusterName:          "my-cluster",
-				GcpProject:           "test-project",
-				Environment:          testEnvironmentName,
-				KanikoImage:          "gcr.io/kaniko-project/executor:v1.1.0",
-				KanikoAdditionalArgs: defaultKanikoAdditionalArgs,
-				DefaultResources:     config.DefaultResources,
+				DockerRegistry:          testDockerRegistry,
+				BuildTimeoutDuration:    timeout,
+				ClusterName:             "my-cluster",
+				GcpProject:              "test-project",
+				Environment:             testEnvironmentName,
+				KanikoImage:             "gcr.io/kaniko-project/executor:v1.1.0",
+				KanikoAdditionalArgs:    defaultKanikoAdditionalArgs,
+				SupportedPythonVersions: defaultSupportedPythonVersions,
+				DefaultResources:        config.DefaultResources,
 				Tolerations: []v1.Toleration{
 					{
 						Key:      "image-build-job",
@@ -823,17 +827,18 @@ func TestBuildImage(t *testing.T) {
 					BuildContextURI: testBuildContextURL,
 					DockerfilePath:  "./Dockerfile",
 				},
-				DockerRegistry:       config.DockerRegistry,
-				BuildTimeoutDuration: config.BuildTimeoutDuration,
-				ClusterName:          config.ClusterName,
-				GcpProject:           config.GcpProject,
-				Environment:          config.Environment,
-				KanikoImage:          config.KanikoImage,
-				KanikoAdditionalArgs: defaultKanikoAdditionalArgs,
-				DefaultResources:     config.DefaultResources,
-				MaximumRetry:         config.MaximumRetry,
-				NodeSelectors:        config.NodeSelectors,
-				Tolerations:          config.Tolerations,
+				DockerRegistry:          config.DockerRegistry,
+				BuildTimeoutDuration:    config.BuildTimeoutDuration,
+				ClusterName:             config.ClusterName,
+				GcpProject:              config.GcpProject,
+				Environment:             config.Environment,
+				KanikoImage:             config.KanikoImage,
+				KanikoAdditionalArgs:    defaultKanikoAdditionalArgs,
+				SupportedPythonVersions: defaultSupportedPythonVersions,
+				DefaultResources:        config.DefaultResources,
+				MaximumRetry:            config.MaximumRetry,
+				NodeSelectors:           config.NodeSelectors,
+				Tolerations:             config.Tolerations,
 			},
 		},
 		{