chore(merlin): Update merlin and mlflow versions #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
force-pushed
the
update_merlin_mlflow_image
branch
from
b1bdebd to
b861816
Compare
deadlycoconuts
commented
Nov 19, 2024
Comment on lines
+239
to
+249
| ObservabilityPublisher: | ||
| KafkaConsumer: | ||
| Brokers: "kafka-brokers" | ||
| DefaultResources: | ||
| Requests: | ||
| CPU: "1" | ||
| Memory: "1Gi" | ||
| Limits: | ||
| CPU: "2" | ||
| Memory: "1Gi" | ||
| EnvironmentName: id-dev |
There was a problem hiding this comment.
I had to add these dummy configs in because there were validation checks on these fields:
tiopramayudi
approved these changes
Nov 19, 2024
|
Thanks for the quick review! Merging this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the recent changes in the Merlin repo to update both the Merlin API server and Mlflow server, this PR updates the versions of these components in the Merlin Helm chart to ensure that the latest versions get deployed by default.
Main Modifications
ghcr.io/gojek/mlflow:1.3.0image for Mlflow toghcr.io/caraml-dev/mlflow:1.26.1v0.38.0-rc1tov0.45.3KanikoPushRegistryTypefield to the default values file as it is now required in the newer version of the Merlin API serverChecklist