Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(caraml): harmonize version label #391

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Conversation

mbruner
Copy link
Member

@mbruner mbruner commented Dec 11, 2023

Motivation

Version labels can be helpful during debugging. It is also shown on the Kiali dashboard.

Modification

Add version label to main CaraML components

Checklist

  • Chart version bumped
  • README.md updated

@mbruner mbruner requested a review from a team as a code owner December 11, 2023 14:01
Copy link
Collaborator

@maniteja6799 maniteja6799 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a few edge cases, added a few comments. The rest looks good to me.

charts/merlin/templates/_helpers.tpl Show resolved Hide resolved
charts/mlp/templates/_helpers.tpl Outdated Show resolved Hide resolved
charts/merlin/templates/_helpers.tpl Show resolved Hide resolved
@mbruner mbruner merged commit e825acb into main Dec 12, 2023
3 checks passed
@mbruner mbruner deleted the harmonize-version-label branch December 12, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants