Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Modify caraml components to accept annotations #382

Merged
merged 12 commits into from
Dec 7, 2023
Merged

feat: Modify caraml components to accept annotations #382

merged 12 commits into from
Dec 7, 2023

Conversation

shydefoo
Copy link
Contributor

@shydefoo shydefoo commented Dec 5, 2023 •
edited
Loading

Motivation

  • Caraml deployment templates do not specify a way to add annotations. This PR modifies the components (merlin, turing, xp-*, mlp) to render annotations in the deployment.

Modification

Checklist

  • [ x] Chart version bumped
  • [ x] README.md updated

@shydefoo shydefoo changed the title Modify caraml components to accept annotations feat: Modify caraml components to accept annotations Dec 5, 2023
@shydefoo shydefoo force-pushed the modify-templates-to-allow-annotations branch 3 times, most recently from 175b9ff to 4cb2f5b Compare December 6, 2023 03:21
@shydefoo shydefoo marked this pull request as ready for review December 6, 2023 06:54
@shydefoo shydefoo requested a review from a team as a code owner December 6, 2023 06:54
maniteja6799
maniteja6799 reviewed Dec 6, 2023
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
charts/turing/ci/ci-values.yaml Outdated Show resolved Hide resolved
charts/mlp/Chart.yaml Outdated Show resolved Hide resolved
charts/xp-management/values.yaml Outdated Show resolved Hide resolved
charts/xp-treatment/ci/ci-values.yaml Outdated Show resolved Hide resolved
charts/merlin/ci/ci-values.yaml Outdated Show resolved Hide resolved
@shydefoo shydefoo force-pushed the modify-templates-to-allow-annotations branch from 4cb2f5b to ed2c0cb Compare December 6, 2023 07:28
@shydefoo shydefoo requested a review from maniteja6799 December 6, 2023 09:02
@shydefoo shydefoo merged commit c9ef6c7 into main Dec 7, 2023
3 checks passed
@shydefoo shydefoo deleted the modify-templates-to-allow-annotations branch December 7, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maniteja6799 maniteja6799 maniteja6799 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shydefoo @maniteja6799