fix: Allow overwriting of rendered template in merlin and turing charts #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
render
field is incomplete. This MR introduces a new fieldoverwrites
, to overwrite specific fields that the render produces.Modification
render.overwrites
field to overwrite portions of the rendered template.Values.config
and$defaultConfig
For example, the current implementation does not allow the following config to be rendered in merlin:
without setting
rendered
to an empty dictionary. This is because the existing config will be overwritten by the rendered template ifrendered
is set.In order to get around this, a new field
overwrites
is added to therendered
dictionary, which allows users to specify which fields in the rendered template should be overwritten. The same can be applied to turing.overwrites is like an escape hatch, it's not expected to be used except for testing purposes.
defaultConfig
uses some values from.Values.config
which makes it quite hard to use.Values.config
to overwrite the rendered template sometimes, and have the rendered template overwrite other partsChecklist