Skip to content

Commit

Permalink
feat: fix type for extra volume mount (#418)
Browse files Browse the repository at this point in the history
  • Loading branch information
khorshuheng authored May 23, 2024
1 parent 6d54859 commit cb3e68c
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/config/ct.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# See https://github.com/helm/chart-testing#configuration
remote: origin
target-branch: add-feast-ui-chart
target-branch: main
chart-dirs:
- charts
chart-repos:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
fi
- name: Run chart-testing (install)
run: ct install --config .github/config/ct.yaml --excluded-charts kserve,common --print-config
run: ct install --config .github/config/ct.yaml --excluded-charts kserve,common,feast-ui --print-config

- name: Run chart-testing for kserve (install)
env:
Expand Down
2 changes: 1 addition & 1 deletion charts/feast-ui/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: "Feast: ML Feature Store"
name: feast-ui
version: 0.5.0
version: 0.5.1
maintainers:
- email: [email protected]
name: caraml-dev
6 changes: 3 additions & 3 deletions charts/feast-ui/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# feast-ui

![Version: 0.5.0](https://img.shields.io/badge/Version-0.5.0-informational?style=flat-square)
![Version: 0.5.1](https://img.shields.io/badge/Version-0.5.1-informational?style=flat-square)

Feast: ML Feature Store

Expand All @@ -14,8 +14,8 @@ Feast: ML Feature Store

| Key | Type | Default | Description |
|-----|------|---------|-------------|
| feast_ui.extraVolumeMounts | object | `{}` | |
| feast_ui.extraVolumes | object | `{}` | |
| feast_ui.extraVolumeMounts | list | `[]` | |
| feast_ui.extraVolumes | list | `[]` | |
| feast_ui.image.pullPolicy | string | `"IfNotPresent"` | |
| feast_ui.image.registry | string | `""` | |
| feast_ui.image.repository | string | `"feast-ui"` | |
Expand Down
4 changes: 2 additions & 2 deletions charts/feast-ui/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ feast_ui:
internalPort: 8080


extraVolumes: {}
extraVolumes: []

extraVolumeMounts: {}
extraVolumeMounts: []

livenessProbe:
path: "/api/live"
Expand Down

0 comments on commit cb3e68c

Please sign in to comment.