-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Destination Unreachable for ICMPv6 #128
Implement Destination Unreachable for ICMPv6 #128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
- Coverage 68.57% 68.55% -0.02%
==========================================
Files 65 66 +1
Lines 5906 5973 +67
==========================================
+ Hits 4050 4095 +45
- Misses 1856 1878 +22
Continue to review full report at Codecov.
|
@plumenator @Adenylatcyclase very cool to see this. Before @drunkirishcoder and I give it a good review, can you rebase and bring in the latest changes from the main branch? We changed our error library recently. |
Co-authored-by: Adenylatcyclase <[email protected]>
47b3faa
to
51bc0e0
Compare
Done! |
Thanks @plumenator @Adenylatcyclase. We'll take a gander this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the contribution! good work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and for keeping up w/ our documentation approach too!
Co-authored-by: @Adenylatcyclase
Description
Fixes # (issue) - if applicable
Type of change
Checklist
We based it on Time Exceeded, pretty much copy pasted and renamed identifiers. 😁
This should tick one box off #105