Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update akaunting.yml #1107

Merged
merged 1 commit into from
May 28, 2024
Merged

Update akaunting.yml #1107

merged 1 commit into from
May 28, 2024

Conversation

FDiskas
Copy link
Contributor

@FDiskas FDiskas commented May 27, 2024

Allow to use v3 and v2 of akaunting. There were some changes in ENV. I also removed the redundant db name - it now just takes it from the app name. Sure it can be changed later via ENV variables if needed

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

Allow to use v3 and v2 of akaunting. There were some changes in ENV. I also removed the redundant db name - it now just takes it from the app name. Sure it can be changed later via ENV variables if needed
@FDiskas
Copy link
Contributor Author

FDiskas commented May 27, 2024

I personally still prefer akaunting v2 - it has fewer bugs and limitations

@githubsaturn
Copy link
Collaborator

Thanks!

@githubsaturn githubsaturn merged commit d780218 into caprover:master May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants