Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(file-picker): implements pickDirectory #326

Merged
merged 4 commits into from
Nov 19, 2024
Merged

feat(file-picker): implements pickDirectory #326

merged 4 commits into from
Nov 19, 2024

Conversation

ebarooni
Copy link
Contributor

@ebarooni ebarooni commented Nov 18, 2024 •
edited by robingenz
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Close #16

@ebarooni ebarooni added platform: ios iOS platform platform: android Android platform feature Feature request platform: web Web platform package: file-picker labels Nov 18, 2024
@ebarooni ebarooni self-assigned this Nov 18, 2024
@ebarooni ebarooni requested a review from robingenz November 18, 2024 23:13
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 18, 2024 •
edited
Loading

Open in Stackblitz

@capawesome-team/capacitor-android-battery-optimization

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-android-battery-optimization@326

@capawesome/capacitor-android-dark-mode-support

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-android-dark-mode-support@326

@capawesome-team/capacitor-android-foreground-service

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-android-foreground-service@326

@capawesome/capacitor-app-review

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-app-review@326

@capawesome/capacitor-app-update

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-app-update@326

@capawesome/capacitor-background-task

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-background-task@326

@capawesome/capacitor-badge

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-badge@326

@capawesome/capacitor-cloudinary

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-cloudinary@326

@capawesome-team/capacitor-datetime-picker

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-datetime-picker@326

@capawesome-team/capacitor-file-opener

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-file-opener@326

@capawesome/capacitor-file-picker

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-file-picker@326

@capawesome/capacitor-live-update

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-live-update@326

@capawesome/capacitor-managed-configurations

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-managed-configurations@326

@capawesome/capacitor-photo-editor

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-photo-editor@326

@capawesome/capacitor-posthog

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-posthog@326

@capawesome/capacitor-screen-orientation

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-screen-orientation@326

@capawesome/capacitor-torch

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-torch@326

commit: 6bbbb89

robingenz
robingenz requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great already!

packages/file-picker/src/definitions.ts Show resolved Hide resolved
.changeset/popular-games-prove.md Outdated Show resolved Hide resolved
packages/file-picker/ios/Plugin/FilePickerPlugin.swift Outdated Show resolved Hide resolved
@ebarooni ebarooni linked an issue Nov 19, 2024 that may be closed by this pull request
feat(file-picker): add pickDirectory(...) method #16
Closed
@ebarooni ebarooni requested a review from robingenz November 19, 2024 17:18
robingenz
robingenz approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@robingenz robingenz merged commit e3f377a into main Nov 19, 2024
4 checks passed
@robingenz robingenz deleted the feat/issue-16 branch November 19, 2024 17:36
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robingenz robingenz robingenz approved these changes

Assignees

@ebarooni ebarooni

Labels
feature Feature request package: file-picker platform: android Android platform platform: ios iOS platform platform: web Web platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(file-picker): add pickDirectory(...) method
2 participants
@ebarooni @robingenz