feat: add @capacitor-mlkit/selfie-segmentation package #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trancee
commented
Sep 10, 2023
packages/selfie-segmentation/ios/Plugin/Classes/ProcessImageResult.swift
Outdated
Show resolved
Hide resolved
Yes, it should be complete now. Thanks for the refactoring! |
robingenz
merged commit 09657e8
into
capawesome-team:feat/selfie-segmentation
2 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).I have finally implemented the iOS part. However, I was not able to return an absolute path to the temporary image file that can be displayed in the web app. I am not sure what I am doing wrong, maybe you could have a look at that. It works if I send it as base64 encoded data URI.