fix(barcode-scanning): readBarcodesFromImage(...) throws a null exc…

…eption on Android
capawesome-team · May 4, 2023 · 3261833 · 3261833
1 parent a77946f
commit 3261833
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/slow-snakes-relate.md b/.changeset/slow-snakes-relate.md
@@ -0,0 +1,5 @@
+---
+'@capacitor-mlkit/barcode-scanning': patch
+---
+
+fix(android): `readBarcodesFromImage(...)` throws a null exception
diff --git a/...in/java/io/capawesome/capacitorjs/plugins/mlkit/barcodescanning/BarcodeScannerHelper.java b/...in/java/io/capawesome/capacitorjs/plugins/mlkit/barcodescanning/BarcodeScannerHelper.java
@@ -21,7 +21,7 @@ public class BarcodeScannerHelper {
     public static JSObject createBarcodeResultForBarcode(@NonNull Barcode barcode, @Nullable Point imageSize, @Nullable Point screenSize) {
         Point[] cornerPoints = barcode.getCornerPoints();
         JSArray cornerPointsResult = new JSArray();
-        if (cornerPoints != null || imageSize != null || screenSize != null) {
+        if (cornerPoints != null && imageSize != null && screenSize != null) {
             Point[] normalizedCornerPoints = normalizeCornerPoints(cornerPoints, imageSize, screenSize);
             for (int i = 0; i < normalizedCornerPoints.length; i++) {
                 JSArray cornerPointResult = new JSArray();